chore(node-core): Fix node-core integration test assertions#19219
Merged
andreiborza merged 2 commits intodevelopfrom Feb 6, 2026
Merged
chore(node-core): Fix node-core integration test assertions#19219andreiborza merged 2 commits intodevelopfrom
andreiborza merged 2 commits intodevelopfrom
Conversation
338f3e0 to
efe4482
Compare
Lms24
approved these changes
Feb 6, 2026
Member
Lms24
left a comment
There was a problem hiding this comment.
Good catch and thanks for fixing this so quickly!
Contributor
Codecov Results 📊Generated by Codecov Action |
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We excluded running the node-core integration tests from ci here, but we never ensured they were ran elsewhere.
This PR fixes the failing tests and adds a dedicated step in build.yml.
As for impact: The failing tests were mostly centered around asserting the correct sdk name, and two failing tests around usage of top-level await and one around adding headers to outgoing http requests.
None of these are critical, the last one working when scoped to node 22 (expected, since our http integration on node-core uses diagnostic channels that are only available on node 22). This is not an issue in our node sdk because we use otel's http integration for that.
Closes #19220 (added automatically)