feat(sveltekit): Auto-wire orchestrion build-time instrumentation - #22768
Conversation
|
bugbottinger run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4ac971e. Configure here.
|
|
||
| export default defineConfig({ | ||
| plugins: [ | ||
| // `sentrySvelteKit()` wires up the orchestrion code transform automatically, so |
There was a problem hiding this comment.
l: do we even need to document this here? 😅 like iiuc this will just be the behavior for the plugins our metaframeworks expose and we also don't explicitly list all the other behaviors we get from those
There was a problem hiding this comment.
Yeah superflous, I'll delete it in the next pr
Backport of: #23678 ## Differences to the original PR - `src/vite/sentryVitePlugins.ts`: dropped the `warnOnRemovedBuildOptions(options, ['unstable_sentryVitePluginOptions'])` call. That line is pre-existing context on `develop` from #23366, which removed the option in v11 — v10 still supports it, and `warnOnRemovedBuildOptions` isn't exported from v10's `@sentry/core`. - `src/vite/sentryVitePlugins.ts` (`generateVitePluginOptions`): kept v10's deprecated `sourceMapsUploadOptions` / `unstable_sentryVitePluginOptions` merging untouched. Only this PR's actual change was applied — `adapter` is now destructured out of the options handed to the Vite plugin and the explicit `adapter: svelteKitPluginOptions.adapter` was dropped. The placeholder is `_filtered5` rather than `_filtered3` because v10 filters two extra deprecated options. - `test/vite/sentrySvelteKitPlugins.test.ts`: plugin-count expectations are v10's counts plus one for the new kit config resolver (8/3/4/7), not `develop`'s (9/4/5/8). v10 has no orchestrion Vite plugin — that's #22768, v11-only.
sentrySvelteKit()now adds the orchestrion bundler plugin (@sentry/server-utils/orchestrion/vite) automatically with no manual plugin setup.The Cloudflare adapter is skipped for and handled in a follow up
closes #22681