fix: trace sync improvements #1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaMoelans
commented
Apr 17, 2025
JoshuaMoelans
commented
Apr 17, 2025
JoshuaMoelans
commented
Apr 17, 2025
JoshuaMoelans
commented
Apr 17, 2025
JoshuaMoelans
commented
Apr 24, 2025
JoshuaMoelans
commented
Apr 25, 2025
Closed
3 tasks
8 tasks
# Conflicts: # CHANGELOG.md
supervacuus
approved these changes
May 7, 2025
There was a problem hiding this comment.
This looks good! Thanks, @JoshuaMoelans. Do you still want to add integration tests for some of the modelled use cases, or do you think the unit tests cover things well enough?
Have you tried to run this inside sentry-android (using a local version of the ndk package)?
|
I think integration tests make sense; currently the unit tests only ensure that spans get created properly, not that they leave the native SDK with the expected values. I will add those before merging 👍 Local testing with |
JoshuaMoelans
added a commit
to getsentry/sentry-docs
that referenced
this pull request
May 9, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> [vercel preview](https://develop-docs-git-feat-nativetracingoverview.sentry.dev/sdk/platform-specifics/native-sdks/tracing/) ## DESCRIBE YOUR PR Related to getsentry/sentry-native#1200 where we reworked the way the Sentry Native SDK handles tracing. Todo - [x] introductory text - [x] add visualizations ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) --------- Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
…nts' into joshua/feat/trace_sync_improvements
6 tasks
supervacuus
approved these changes
May 13, 2025
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
JoshuaMoelans
added a commit
to getsentry/sentry-docs
that referenced
this pull request
May 13, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> [Vercel Preview](https://sentry-docs-htn2uy3fb.sentry.dev/platforms/native/tracing/instrumentation/custom-instrumentation/#:~:text=it%20to%20Sentry.-,By%20default%2C,-transactions%20will%20inherit) ## DESCRIBE YOUR PR Related to the feature added in getsentry/sentry-native#1137 & the update to native tracing in getsentry/sentry-native#1200 Since transactions no longer create a new `trace_id`, we want to document how to set up a trace boundary with `sentry_set_trace()`. ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs)
1 task
bitsandfoxes
pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> [vercel preview](https://develop-docs-git-feat-nativetracingoverview.sentry.dev/sdk/platform-specifics/native-sdks/tracing/) ## DESCRIBE YOUR PR Related to getsentry/sentry-native#1200 where we reworked the way the Sentry Native SDK handles tracing. Todo - [x] introductory text - [x] add visualizations ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) --------- Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
bitsandfoxes
pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> [Vercel Preview](https://sentry-docs-htn2uy3fb.sentry.dev/platforms/native/tracing/instrumentation/custom-instrumentation/#:~:text=it%20to%20Sentry.-,By%20default%2C,-transactions%20will%20inherit) ## DESCRIBE YOUR PR Related to the feature added in getsentry/sentry-native#1137 & the update to native tracing in getsentry/sentry-native#1200 Since transactions no longer create a new `trace_id`, we want to document how to set up a trace boundary with `sentry_set_trace()`. ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the investigation of #1167
The aim of this PR is to rework the way we handle trace syncing (e.g. with
set_trace) and how this affects data inside events & spans.There's
ToDosleft in the code to indicate some parts of the implementation left to discuss.propagation_contextforset_tracepropagation_contextfor new/scoped spansset_trace)#skip-changelog for now