Add FreeBSD platform detection to sentry.h #1221
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend platform detection logic to recognize FreeBSD as a supported platform. Define SENTRY_PLATFORM_FREEBSD and SENTRY_PLATFORM_UNIX macros when compiling on FreeBSD. It's sufficient for the overall build to work without any additional modifications to the cpp files as FreeBSD is compatible with the existing Unix platform code.
|
Hi @mq1n. Can you explain what you want to achieve with these changes? I detailed the changes for FreeBSD to become a community-supported platform (support from Sentry would at least require the tests to run in CI) for the Native SDK: #1113 (comment) By just adding a marker for FreeBSD and making it a UNIX, a considerable part of the Native SDK features will not work. |
|
Closing due to inactivity. Please feel free to reopen at any time if you like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend platform detection logic to recognize FreeBSD as a supported platform.
Define SENTRY_PLATFORM_FREEBSD and SENTRY_PLATFORM_UNIX macros when compiling on FreeBSD. It's sufficient for the overall build to work without any additional modifications to the cpp files as FreeBSD is compatible with the existing Unix platform code.