-
-
Notifications
You must be signed in to change notification settings - Fork 192
feat: add sentry_regenerate_trace()
#1293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
5 tasks
supervacuus
approved these changes
Jul 1, 2025
JoshuaMoelans
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 1, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> [Current docs](https://docs.sentry.io/platforms/native/tracing/instrumentation/custom-instrumentation/) [Updated docs (vercel preview)](https://sentry-docs-git-joshua-settraceclarification.sentry.dev/platforms/native/tracing/instrumentation/custom-instrumentation/#trace-boundaries) ## DESCRIBE YOUR PR Adding some more detailed explanation on the Native handling of trace boundaries & when/how to set a new trace. Only merge after getsentry/sentry-native#1293 ToDo - [x] add better explanation - [x] ? provide example of generating new trace/span ID? - we don't really have an API for this (yet), but we could reuse `sentry_uuid_t uid = sentry_uuid_new_v4();`? -> added in getsentry/sentry-native#1293 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ --------- Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
bitsandfoxes
pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> [Current docs](https://docs.sentry.io/platforms/native/tracing/instrumentation/custom-instrumentation/) [Updated docs (vercel preview)](https://sentry-docs-git-joshua-settraceclarification.sentry.dev/platforms/native/tracing/instrumentation/custom-instrumentation/#trace-boundaries) ## DESCRIBE YOUR PR Adding some more detailed explanation on the Native handling of trace boundaries & when/how to set a new trace. Only merge after getsentry/sentry-native#1293 ToDo - [x] add better explanation - [x] ? provide example of generating new trace/span ID? - we don't really have an API for this (yet), but we could reuse `sentry_uuid_t uid = sentry_uuid_new_v4();`? -> added in getsentry/sentry-native#1293 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ --------- Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the upcoming docs change getsentry/sentry-docs#14201 ;
We don't want users interacting with the
sentry_set_trace(trace_id, parent_span_id)
interface directly (as this is mainly meant for downstream SDKs to call into), so we provide an alternative way to specify a 'trace boundary'.