fix: correctly apply dynamic mutex initialization in unit-tests #1337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaind
approved these changes
Aug 15, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the tsan introduction, we also introduced mutexes into the unit tests to properly synchronize some of the test-runners (e.g., acutest has internals that are not thread-safe, for instance, updating records of check results until the test finishes). Sadly, I forgot to cover dynamic mutexes in the two test modules, which are currently not integrated in CI.
This PR only provides fixes for the failing downstream builds. However, we can restructure the mutex setup to eliminate the need to cover dynamic mutex initialization, thereby avoiding a separate test path for mutex initialization.
Raised here: #1309 (comment)
#skip-changelog