Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: update traces_sampler to also take user_data argument #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 11, 2025
Merged

fix: update traces_sampler to also take user_data argument #1346

merged 7 commits into from
Sep 11, 2025

Conversation

JoshuaMoelans
Copy link
Member

fixes #1345

@JoshuaMoelans JoshuaMoelans mentioned this pull request Aug 28, 2025
Closed
jpnurmi
jpnurmi reviewed Sep 1, 2025
View reviewed changes
Copy link
Collaborator

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks on behalf of downstream SDKs! :) This looks good, no need to inject internal values into the user's sampling context.

@JoshuaMoelans JoshuaMoelans marked this pull request as ready for review September 1, 2025 13:47
jpnurmi
jpnurmi approved these changes Sep 1, 2025
View reviewed changes
Copy link
Collaborator

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I hope @supervacuus is ok with the break.

@JoshuaMoelans
Copy link
Member Author

(this would become part of the same release that includes the first Logs implementation for native, so I think bundling this in as a breaking change for native 0.11.0 is fine)

supervacuus
supervacuus approved these changes Sep 2, 2025
View reviewed changes
Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am not happy that we have to break here, and I would argue that a second option setter + callback type is fine here.

However, the API is marked as experimental, very new, and having two just for the sampler is probably more confusing. So, whiny LGTM.

@JoshuaMoelans JoshuaMoelans merged commit 89e25d4 into master Sep 11, 2025
40 checks passed
@JoshuaMoelans JoshuaMoelans deleted the joshua/feat/traces_sampler_user_data branch September 11, 2025 12:51
@BrewTestBot BrewTestBot mentioned this pull request Sep 18, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpnurmi jpnurmi jpnurmi approved these changes

@supervacuus supervacuus supervacuus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sentry_options_set_traces_sampler is missing a user data argument
3 participants
@JoshuaMoelans @jpnurmi @supervacuus