fix: Add Xbox networking initialization to WinHTTP transport #1359
Conversation
- Add Xbox-specific network initialization before WinHTTP operations - Ensures Xbox XNetworking APIs are ready before HTTP requests - Fixes WinHTTP error 12007 (ERROR_WINHTTP_CANNOT_CONNECT) on Xbox platforms - Uses 60-second timeout to prevent indefinite blocking - Graceful failure with warning when network not ready - Minimal changes using existing SENTRY_PLATFORM_XBOX ifdef pattern Addresses Xbox networking requirements where WinHTTP needs network connectivity to be established through Xbox-specific APIs before HTTP operations can succeed.
| # include "sentry_transport_xbox.h" | ||
| #endif |
There was a problem hiding this comment.
Potential bug: The code includes a non-existent header sentry_transport_xbox.h and calls an undefined function, causing fatal compilation errors when building for the Xbox platform.
-
Description: The change introduces an
#include "sentry_transport_xbox.h"directive and a call tosentry__xbox_ensure_network_initialized()within an#ifdef SENTRY_PLATFORM_XBOXblock. Neither the header file nor the function definition exists within the repository. Consequently, any attempt to compile the code with theSENTRY_PLATFORM_XBOXmacro defined will result in a fatal compilation error, such asfatal error: sentry_transport_xbox.h: No such file or directory. This breaks the build for the Xbox platform, which is a major functional regression. This approach is also inconsistent with existing patterns for Xbox-specific code, which typically use no-op implementations rather than relying on missing external dependencies. -
Suggested fix: The missing
sentry_transport_xbox.hheader and the implementation forsentry__xbox_ensure_network_initialized()should be added. Alternatively, if these are provided by a separate repository, the build should handle their absence gracefully, for example by using weak symbols or providing a no-op fallback implementation to ensure the main repository remains buildable on its own.
severity: 0.85, confidence: 1.0
Did we get this right? 👍 / 👎 to inform future reviews.
Fixes WinHTTP error 12007 on Xbox platforms by adding network initialization check before HTTP requests.
Xbox platforms require XNetworking API initialization before WinHTTP can connect. This change adds a minimal ifdef to call Xbox-specific network initialization (implemented in downstream sentry-xbox repo) with graceful failure when network isn't ready.
Note: there's an unrelated CI failure, see #1360