feat: Implement logging enable/disable feature, with crash handler options #1371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mujacica
commented
Sep 15, 2025
- Added a feature to enable/disable logging
- Added a new option to enable/disable logging during crash handling
- Extended tests for the new functionality
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
supervacuus
approved these changes
Sep 15, 2025
vaind
reviewed
Sep 15, 2025
supervacuus
requested changes
Sep 15, 2025
There was a problem hiding this comment.
Given @vaind's valid review points, there are open todos:
- (maybe) eliminate logging reenablement
- if you keep it, it should be moved beyond the
sentry__leave_signal_handler();boundary - a basic integration test that validates the crash case on all platforms + backends
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1371 +/- ##
===========================================
- Coverage 83.74% 45.49% -38.26%
===========================================
Files 56 56
Lines 8769 8815 +46
Branches 1367 1385 +18
===========================================
- Hits 7344 4010 -3334
- Misses 1297 4805 +3508
+ Partials 128 0 -128 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
supervacuus
requested changes
Sep 16, 2025
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
supervacuus
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.