tests: remove flaky logger test from transport suite #1378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a minor follow-up to the logger when crashed options, @mujacica. |
|
Btw, the failing |
mujacica
approved these changes
Sep 17, 2025
| bool assert_now; | ||
| } logger_test_t; | ||
|
|
||
| // Note: All logger unit-tests must only run from the transportless unit-test |
There was a problem hiding this comment.
Thanks for adding a comment, makes sense to exclude these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logger unit tests are always written from a single-threaded perspective. As such, they should be running inside the transport-based test suite since the transport could be concurrently logging and thus would lead to flaky test assertions.
#skip-changelog