Serialize Enum variants with the variant name #1860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs changes to only run the tests in PHP 8.1+ but otherwise, great! |
|
Yeah already working on it, didn't realize 7.* was still supported. |
Jean85
suggested changes
Jun 12, 2025
47ec155 to
9fdeca8
Compare
With enum types it's almost always useful to know exactly which variant is being logged. But the current serializers don't differentiate between enums and objects. This changes the serializers to add the variant name of the enum that is being serialized.
Jean85
approved these changes
Jun 12, 2025
stayallive
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With enum types it's almost always useful to know exactly which variant is being logged. But the current serializers don't differentiate between enums and objects.
This changes the serializers to add the variant name of the enum that is being serialized.