Fix handling of backtrace frames #1862
Conversation
|
@poldixd could you give this a try and lmk if it fixes your issue? I'm not sure in which cases this problem can actually happen, hence the fix is purely based on a synthetic test. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of backtrace frames by correctly reindexing variadic function arguments, ensuring that gaps in the backtrace indices are handled properly.
- Added a test to verify that gaps in backtrace array indices are correctly processed
- Simplified the code by replacing a loop with array_slice and array_values to extract and reindex variadic arguments
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/FrameBuilderTest.php | Added a test for verifying proper handling of gaps in backtrace args |
| src/FrameBuilder.php | Replaced loop with array_slice and array_values for variadic arguments |
|
Thanks! The issue is now resolved on my end. My original code looked like this and I created a test for this exception: try {
$contactPerson->addMediaFromUrl('foo.bar')
->preservingOriginal()
->toMediaCollection(Attachment::MEDIALIBRARY_COLLECTIONNAME);
} catch (UnreachableUrl $th) {
report($th);
}It’s possible that the exception So far, everything seems to work fine with your fix—thanks again! |
Fixes #1861