Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use span attrs in GCP sampling context #3818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 28, 2024
Merged

Use span attrs in GCP sampling context #3818

merged 6 commits into from
Nov 28, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Nov 22, 2024 •
edited
Loading

  • add initial span attrs and get rid of custom sampling context
  • add one extra span attr to aws too
  • update tests

@codecov Codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

❌ 885 Tests Failed:

Tests completed Failed Passed Skipped
19529 885 18644 4424
View the top 3 failed tests by shortest run time 
tests.integrations.opentelemetry.test_span_processor test_on_start_transaction
Stack Traces | 0.001s run time 
.../integrations/opentelemetry/test_span_processor.py:289: in test_on_start_transaction
    fake_start_transaction,
.../hostedtoolcache/Python/3.7.17....../x64/lib/python3.7/unittest/mock.py:1307: in __enter__
    original, local = self.get_original()
.../hostedtoolcache/Python/3.7.17....../x64/lib/python3.7/unittest/mock.py:1281: in get_original
    "%s does not have the attribute %r" % (target, name)
E   AttributeError: <module 'sentry_sdk.integrations.opentelemetry.span_processor' from '.../integrations/opentelemetry/span_processor.py'> does not have the attribute 'start_transaction'
tests.integrations.opentelemetry.test_span_processor test_on_start_transaction
Stack Traces | 0.001s run time 
.../integrations/opentelemetry/test_span_processor.py:289: in test_on_start_transaction
    fake_start_transaction,
.../hostedtoolcache/Python/3.7.17....../x64/lib/python3.7/unittest/mock.py:1307: in __enter__
    original, local = self.get_original()
.../hostedtoolcache/Python/3.7.17....../x64/lib/python3.7/unittest/mock.py:1281: in get_original
    "%s does not have the attribute %r" % (target, name)
E   AttributeError: <module 'sentry_sdk.integrations.opentelemetry.span_processor' from '.../integrations/opentelemetry/span_processor.py'> does not have the attribute 'start_transaction'
tests.integrations.opentelemetry.test_span_processor test_on_start_transaction
Stack Traces | 0.002s run time 
.../integrations/opentelemetry/test_span_processor.py:287: in test_on_start_transaction
    with mock.patch(
.../hostedtoolcache/Python/3.12.7....../x64/lib/python3.12/unittest/mock.py:1463: in __enter__
    original, local = self.get_original()
.../hostedtoolcache/Python/3.12.7....../x64/lib/python3.12/unittest/mock.py:1436: in get_original
    raise AttributeError(
E   AttributeError: <module 'sentry_sdk.integrations.opentelemetry.span_processor' from '.../integrations/opentelemetry/span_processor.py'> does not have the attribute 'start_transaction'

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@sentrivana sentrivana mentioned this pull request Nov 25, 2024
Closed
12 tasks
@sentrivana sentrivana marked this pull request as ready for review November 28, 2024 13:37
@sentrivana sentrivana merged commit 5beea99 into potel-base Nov 28, 2024
47 of 122 checks passed
@sentrivana sentrivana deleted the ivana/potel/custom-sampling-context-gcp branch November 28, 2024 13:57
@sentrivana sentrivana mentioned this pull request Nov 28, 2024
Draft
@BYK BYK mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

@antonpirker antonpirker Awaiting requested review from antonpirker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sentrivana @sl0thentr0py