fix(docs): Fix docstring in ignore_logger
#400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
reviewed
Jun 24, 2019
| of this integration. | ||
| """This disables recording (both in breadcrumbs and as events) calls to | ||
| a logger of a specific name. Among other uses, many of our integrations | ||
| use this to prevent their actions being recorded as breadcrumbs. Exposed |
There was a problem hiding this comment.
to prevent their actions being recorded as breadcrumbs
More precisely, the integrations use this to suppress spam breadcrumbs/events from the framework that would be sent if the integration was disabled. A classic is sending a stringified traceback as log message, or more generally a log error by the framework for every exception we already recorded via other means
There was a problem hiding this comment.
Ah, I now understand what their means in this context, nvm my comment.
untitaker
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this function will block regular event recording as well as breadcrumb recording.