ref(wsgi): Update _werkzeug vendor to newer version #4793
Conversation
| host = host[:-3] | ||
| elif scheme in {"https", "wss"} and host.endswith(":443"): | ||
| host = host[:-4] | ||
|
|
There was a problem hiding this comment.
📝 Here werkzeug have a condition for trusted hosts: https://github.com/pallets/werkzeug/blob/3.1.3/src/werkzeug/sansio/utils.py#L98
Why we don't use it?
There was a problem hiding this comment.
I assume because we're only using the get_host function to reconstruct the request URL and not any actual functionality.
| host = f"[{host}]" | ||
|
|
||
| if server[1] is not None: | ||
| host = f"{host}:{server[1]}" # noqa: E231 |
There was a problem hiding this comment.
🎗️ I had to define this because of:
E231 missing whitespace after ':'
75b9810 to
dab33fb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4793 +/- ##
==========================================
- Coverage 84.47% 83.41% -1.07%
==========================================
Files 158 158
Lines 16506 16512 +6
Branches 2865 2864 -1
==========================================
- Hits 13944 13773 -171
- Misses 1712 1889 +177
Partials 850 850
|
ba2c350 to
6238c21
Compare
| return None | ||
|
|
||
| try: | ||
| port = int(environ.get("SERVER_PORT", None)) # type: ignore[arg-type] |
There was a problem hiding this comment.
This # type was introduced in main branch not in 3.1.3
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Thanks for the PR @mgaligniana -- I think the |
6238c21 to
b4ee7ae
Compare
| ( | ||
| environ.get("HTTP_HOST") | ||
| if not use_x_forwarded_for | ||
| else environ.get("HTTP_X_FORWARDED_HOST") | ||
| ), |
There was a problem hiding this comment.
🎗️ The previous condition was: if use_x_forwarded_for and "HTTP_X_FORWARDED_HOST" in environ:
But if we have use_x_forwarded_for in True doesn't mean HTTP_X_FORWARDED_HOST will be present?
|
Ok, Seer 🎉 liked! But codecov not, should I add new tests for the new vendor? Edited: I think yes because Anton said:
But do you think I should copy-paste the test from werkzeug to get_host for example? |
Fixes GH-3516