fix: send trace origin correctly #906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #906 +/- ##
==========================================
+ Coverage 73.44% 73.46% +0.01%
==========================================
Files 64 64
Lines 7502 7506 +4
==========================================
+ Hits 5510 5514 +4
Misses 1992 1992 🚀 New features to boost your workflow:
|
szokeasaurusrex
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #858 we added reporting for trace origin.
The implementation there was actually incorrect because we attached
originto the trace data.Instead, we need to add a new field on
TraceContextcalledorigin, and write it there.Technically this is a breaking change, but I imagine it's very unlikely that a user needs to construct this struct.
Issues
Closes #907
Closes RUST-110