Push to the sentry transaction #160
Conversation
mcfedr
commented
Oct 1, 2018
- At start and end of request, using _route attribute if its set
- At start and end of commands, using command name
| { | ||
| $mockEvent = $this->createMock(ConsoleCommandEvent::class); | ||
|
|
||
| $command = new Command(); |
There was a problem hiding this comment.
This is making the test fail in --prefer-lowest; need a name.
There was a problem hiding this comment.
Yes, just looking at how to do this for Symfony 3
| * | ||
| * @param FinishRequestEvent $event | ||
| */ | ||
| public function onFinishRequest(FinishRequestEvent $event): void; |
There was a problem hiding this comment.
These new methods are a huge breaking change 😞 I don't think I can merge this right now as it is...
There was a problem hiding this comment.
How is best to do this? I see that currently in the interface it also doesnt have onConsoleCommand, but its in the ExceptionListener, maybe this can also just not be added to the interface?
|
The transaction value gets a special treatment in Sentry UI, here
it is also show amongst the tags:
|
1c23f5e to
8dc2538
Compare
- At start and end of request, using _route attribute if its set - At start and end of commands, using command name
|
The remaining phpstan issues are caused by getsentry/sentry-php#660 |
|
I've changed the target branch due to the fact that #184 will start development of 3.0 on the master branch. Unfortunately there are conflicts that need to be resolved first. Anyhow, I'm planning on using |
|
Just re-implemented the same in #198 for 3.x. |
|
Closing as this is fixed with #198 |