Messenger: capture_soft_fails:false doesn't work #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, the bug seems to be absent on 4.3: https://travis-ci.org/github/getsentry/sentry-symfony/jobs/704627016 [EDIT] This is due symfony/symfony@d7e0f98; the offending listener was created there, since the Messenger received BC up until 4.4, where it was no longer experimental. |
f2cd590 to
f18b440
Compare
|
@emarref this is ready, can you test it out? |
|
I personally tested this in production, it works. |
|
Sorry about that. I've been under the gun with a deadline. It looks like it should work well. I'm still not sure why it was working OK for me in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stems from #326 (comment): I've noticed that the
capture_soft_failsoption is not working for me, because thewillRetryflag is set later, in a different listener with a priority of 100, where our listener has a default priority of 128.