feat(cache): enable auto-instrumentation for symfony cache #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
cleptric
approved these changes
Sep 11, 2025
| */ | ||
| public static function getCacheItemSize($value): ?int | ||
| { | ||
| if (\is_string($value)) { |
There was a problem hiding this comment.
Let's add a comment why we only gather the payload size on strings for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces auto-instrumentation for Symfony cache.
Symfony cache works slightly different than PSR-6 Cache. Instead of having an explicit put or save method, it provides a callback which is invoked on a cache miss.
Sentry will now auto instrument those and will provide proper spans. If the callback produces spans, those spans will be visible in the trace explorer to give further insights to the cache operation.
This PR also updates the
span.op. Previously, it just used the PSR-6 method names as span op, which would not work with the Cache Module.