llama : use cmake for swift build #10525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a73ca52 to
27432b6
Compare
Merged
27432b6 to
47844dc
Compare
This reverts commit d39ffd9.
MrMage
added a commit
to MrMage/llama.cpp
that referenced
this pull request
Dec 13, 2024
This reverts commit 43ed389.
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Dec 20, 2024
* llama : use cmake for swift build * swift : <> -> "" * ci : remove make * ci : disable ios build * Revert "swift : <> -> """ This reverts commit d39ffd9. * ci : try fix ios build * ci : cont * ci : cont --------- Co-authored-by: Georgi Gerganov <[email protected]>
MrMage
added a commit
to MrMage/llama.cpp
that referenced
this pull request
Jan 27, 2025
This reverts commit 43ed389.
tinglou
pushed a commit
to tinglou/llama.cpp
that referenced
this pull request
Feb 13, 2025
* llama : use cmake for swift build * swift : <> -> "" * ci : remove make * ci : disable ios build * Revert "swift : <> -> """ This reverts commit d39ffd9. * ci : try fix ios build * ci : cont * ci : cont --------- Co-authored-by: Georgi Gerganov <[email protected]>
|
Changing this to a system library breaks the SwiftPM integration (basically the only relevant use case) and forces every users to clone the repo. The build instructions NEED to remain in the |
|
@Lancelotbronner The Swift builds are being migrated to a XCFramework. Follow #11996 for updates. |
|
I know it's already been merged months ago, but Swift isn't just for Apple platform development. XCFramework won't work on Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to show a possible way to use
cmaketo build the llama.cpp dependency for the swift code, without having to duplicate the build inPackage.swift.