cuda: Use common gfx8 value for GCN4 #11209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocm_agent_enumerator returns the two values 800 and 803 with the former being used by this API
|
Here is my output: Will 803 not be functional anymore? |
It only returns one ID per device although ROCM can have multiple, you'll need to check to see which one is actually being used. The gfx000 should say gfx800, which version of ROCM are you using? edit: |
|
While looking at the code to parse the device properties it appears the minor version is shifted up a decimal place such that any device IDs requiring the first digit will never match. I'm going to hold back on this for a moment since it requires more attention than I initially thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rocm_agent_enumerator returns the two values 800 and 803 with the former being used by this API
Make sure to read the contributing guidelines before submitting a PR