vulkan: support multi/vision rope, and noncontiguous rope #11902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be677aa to
c7bf8d5
Compare
0cc4m
approved these changes
Feb 16, 2025
This was referenced Feb 17, 2025
LostRuins
added a commit
to LostRuins/koboldcpp
that referenced
this pull request
Feb 20, 2025
Renable qwen2vl GPU for vulkan ggml-org#11902 # Conflicts: # .github/workflows/build.yml # .github/workflows/docker.yml # .gitignore # CONTRIBUTING.md # Makefile # common/CMakeLists.txt # common/arg.cpp # common/common.cpp # examples/main/main.cpp # examples/run/run.cpp # examples/server/tests/README.md # ggml/src/ggml-cuda/mma.cuh # scripts/get_chat_template.py # tests/test-backend-ops.cpp # tests/test-chat-template.cpp # tests/test-chat.cpp
4 tasks
orca-zhang
pushed a commit
to orca-zhang/llama.cpp
that referenced
this pull request
Feb 26, 2025
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Feb 26, 2025
mglambda
pushed a commit
to mglambda/llama.cpp
that referenced
this pull request
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the qwen2vl clip failures discussed in #11322 and #10843. These ops weren't supported but apparently they were being executed by the vulkan backend regardless.
This is based on the CUDA code, and I switched some of the names in the existing rope shaders to match that.