llama : fix llama_model_chat_template with template name (LLM_KV with suffix) #14050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
approved these changes
Jun 6, 2025
There was a problem hiding this comment.
This particular case looks good to me.
However, I'm just wondering if this suffix is currently used by other KV metadata. For example, the old logic will work with something like %s.key.%s (which will be replaced by arch.key.suffix), but will now breaks. So I think we should still verify this before merging
|
I've grepped the sources and there doesn't appear to be any other usage of LLM_KV with suffix, and there are no other keys with a %s for anything other than arch, so I think it's safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suffix was never applied, and in the case of
llama_model_chat_templatearch was appended instead of suffix.