kv-cache : relax SWA masking condition #14119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c121b6e to
989b8c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #14111
Allow to insert the ubatch in any SWA-masked position - not only at the minimum.
Before, we required that the new ubatch could overwrite only the minimum sequence positions in order to guarantee that all tokens in the range
[pos_min(s), pos_max(s)]will always be present in the cache. Now we can insert the ubatch at any position as long as it is SWA-maksed. In order to preserve the invariant, we have to purge any tokens with positions smaller than those that were overwritten by the ubatch.