Improve build-info.cpp generation #14156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rebuild of build-info.cpp still gets triggered when .git/index gets changes.
35480fb to
ad08795
Compare
ggerganov
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify it, and generate it in the build dir, rather than the source dir.
For one, keeping
common/cmake/build-info-gen-cpp.cmakeout of the maincmake/is confusing, especially since it depends oncmake/build-info.cmakethere.Also the
add_custom_command(cmake ... -P script)didn't inherit any variables which means they had to be passed on explicitly. I needed to add variables but this became convoluted so I simplified it instead.I assume that the
add_custom_command(cmake)was only added for the dependency on.git/index, I found a workaround for that. This allowed me to drop the complicated stuff and reduce this to aconfigure_filewhich now also writes to the build dir instead of the source dir.