convert : correct gemma 3n conversion #14450
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
commented
Jun 29, 2025
CISC
approved these changes
Jun 29, 2025
ggerganov
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
Btw, the conversion of pretrained Gemma 3n models fails like this:
python convert_hf_to_gguf.py google/gemma-3n-E4B/ --outfile models/gemma-3n-e4b/ggml-model-f16.gguf --outtype f16
Traceback (most recent call last):
File "llama.cpp/convert_hf_to_gguf.py", line 6718, in <module>
main()
File "llama.cpp/convert_hf_to_gguf.py", line 6712, in main
model_instance.write()
File "llama.cpp/convert_hf_to_gguf.py", line 410, in write
self.prepare_metadata(vocab_only=False)
File "llama.cpp/convert_hf_to_gguf.py", line 523, in prepare_metadata
self.set_vocab()
File "llama.cpp/convert_hf_to_gguf.py", line 4411, in set_vocab
with open(self.dir_model / "chat_template.jinja") as f:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'google/gemma-3n-E4B/chat_template.jinja'|
Oh hi - this looks fine! |
Fixed in #14508 |
gabe-l-hart
added a commit
to gabe-l-hart/llama.cpp
that referenced
this pull request
Jul 3, 2025
* origin/master: Fix conditional enabling following arch checks for ggml-sycl (ggml-org#14504) convert : correct gemma 3n conversion (ggml-org#14450) kv-cache : use ggml_set_rows (ggml-org#14285) ggml : fix FA mask dim 2 and 3 (ggml-org#14505) ggml : remove kompute backend (ggml-org#14501) CUDA: add dynamic shared mem to softmax, refactor general usage (ggml-org#14497)
Minh141120
pushed a commit
to menloresearch/llama.cpp
that referenced
this pull request
Jul 5, 2025
* convert : correct gemma 3n conversion * rm redundant code
qnixsynapse
pushed a commit
to menloresearch/llama.cpp
that referenced
this pull request
Jul 6, 2025
* convert : correct gemma 3n conversion * rm redundant code
qnixsynapse
pushed a commit
to menloresearch/llama.cpp
that referenced
this pull request
Jul 6, 2025
* convert : correct gemma 3n conversion * rm redundant code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address problem reported by @danielhanchen : https://huggingface.co/unsloth/gemma-3n-E4B-it-GGUF/discussions/6#6860763b91da860136961b2b