chat : only remove double bos/eos if added #15086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am assuming ggufs will have to be regenerated after this PR lands, right? |
Collaborator
Author
No, this is a parsing fix. |
slaren
approved these changes
Aug 5, 2025
Member
slaren
left a comment
There was a problem hiding this comment.
The change looks reasonable to me, but I don't know if it will break something else. Let's keep an eye on it just in case.
Collaborator
Author
|
It could, but chances are whatever it breaks was broken (aka relying on this behaviour) in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only remove potentially double BOS/EOS token from chat template if
add_bos_tokenoradd_eos_tokenis set, this fixes--jinjaforGLM-4.5as it has[gMask]<sop>in the chat template, with[gMask]as BOS token, butadd_bosisfalse(because both tokens are the real BOS).