Add support for TRUNC unary operator (CPU +SYCL) #16032
Open
+155
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the TRUNC unary operator, applying element-wise truncation (truncf / sycl::trunc) on tensors.
Changes:
CPU (ggml-cpu.c)
Added forward implementation: ggml_compute_forward_trunc
Registered op in scheduler: ggml_get_n_tasks
SYCL (ggml-sycl)
Added device function: op_trunc
Added kernel: unary_op_trunc_kernel
Added dispatch wrapper: ggml_sycl_op_trunc
Exposed API: ggml_sycl_trunc
Tests
Included in backend coverage tests
Support matrix can be regenerated:
./build/bin/test-backend-ops support -o TRUNC --output csv > trunc_support.csv
./scripts/create_ops_docs.py
Produces trunc_support.csv verifying backend availability.
Notes
Implemented for F32 (and F16 where SYCL supports it)
Brings consistency with existing unary ops