Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[email protected] - Build in openSUSE:compatible with gcc7 #5606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[email protected] - Build in openSUSE:compatible with gcc7 #5606

wants to merge 3 commits into from

Conversation

cabelo
Copy link

@cabelo cabelo commented Feb 20, 2024

No description provided.

@cebtenzzre cebtenzzre requested a review from ikawrakow February 22, 2024 20:40
Copy link
Contributor

@ikawrakow ikawrakow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it really work with any GCC version earlier than 7?

@cabelo
Copy link
Author

cabelo commented Feb 23, 2024

Does it really work with any GCC version earlier than 7?

@ikawrakow I can't answer this, do you want me to set the condition to only meet version 7?

@ikawrakow
Copy link
Contributor

do you want me to set the condition to only meet version 7?

I have no strong feelings about this, was just surprised that a) someone is still using GCC 7, and b) the condition was less < 8, so included even earlier versions.

What is the use case for GCC 7 in the year 2024 anyway?

@cebtenzzre
Copy link
Collaborator

I will mention again that it seems like this PR is adding yet another implementation of _mm256_set_m128i
(MM256_SET_M128I is defined above). I don't know which is preferred or why one is conditionally emulated and the other is unconditionally emulated.

@cabelo
Copy link
Author

cabelo commented Feb 23, 2024

do you want me to set the condition to only meet version 7?

I have no strong feelings about this, was just surprised that a) someone is still using GCC 7, and b) the condition was less < 8, so included even earlier versions.

What is the use case for GCC 7 in the year 2024 anyway?

Hi super @ikawrakow
Because I intended to include llama.cpp natively in openSUSE and SUSE Enterprise, and the distribution natively comes with version 7

@cabelo
Copy link
Author

cabelo commented Mar 4, 2024

@ikawrakow Do I need to do anything else?

@slaren
Copy link
Member

slaren commented Mar 5, 2024

I think we should use the MM256_SET_M128I macro everywhere instead of adding another workaround, it was added precisely for this purpose. #2405

@cebtenzzre
Copy link
Collaborator

Fixed in #5889.

@cebtenzzre cebtenzzre closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants