Fix broadcast address being discarded in net_if_addrs on Windows#2836
Merged
Conversation
_replace() returns a new namedtuple instance. Thus, the result needs to be assigned back. Otherwise the computed broadcast address is silently dropped. This fixes a bug with the broadcast field of net_if_addrs() being empty on Windows.
d89c51c to
aa54ada
Compare
Owner
|
/changelog |
Contributor
|
- :gh:`2711`, [Windows]: :func:`net_if_addrs()` was returning ``None`` for
the ``broadcast`` field of network interfaces instead of the correct
broadcast address.
* :user:`Tobias Klauser <tklauser>` - :gh:`2711` |
Owner
|
Yes, that was clearly a bug that passed unnoticed. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
net_if_addrsstill none with psutil > 7.0.0 #2711Description
_replace()returns a newnamedtupleinstance. Thus, the result needs to be assigned back. Otherwise the computed broadcast address is silently dropped. This fixes a bug with thebroadcastfield ofnet_if_addrs()being empty on Windows.