Support negative Content-Length in DataFromReader#1981
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1981 +/- ##
==========================================
+ Coverage 98.69% 98.69% +<.01%
==========================================
Files 40 40
Lines 2228 2229 +1
==========================================
+ Hits 2199 2200 +1
Misses 16 16
Partials 13 13
Continue to review full report at Codecov.
|
You can get an http.Response with ContentLength set to -1 (Chunked encoding), so for DataFromReader to be useful for those we need to support that.
thinkerou
approved these changes
Jul 8, 2019
foundations
pushed a commit
to foundations/gin
that referenced
this pull request
Aug 7, 2019
Support negative Content-Length in DataFromReader (gin-gonic#1981)
ThomasObenaus
pushed a commit
to ThomasObenaus/gin
that referenced
this pull request
Feb 19, 2020
You can get an http.Response with ContentLength set to -1 (Chunked encoding), so for DataFromReader to be useful for those we need to support that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can get an http.Response with ContentLength set to -1 (Chunked encoding), so for DataFromReader to be useful for those we need to support that.