Thanks to visit codestin.com
Credit goes to github.com

Skip to content

use http method constant#2155

Merged
thinkerou merged 3 commits into
gin-gonic:masterfrom
thinkerou:httpStatus
Nov 28, 2019
Merged

use http method constant#2155
thinkerou merged 3 commits into
gin-gonic:masterfrom
thinkerou:httpStatus

Conversation

@thinkerou

Copy link
Copy Markdown
Member

No description provided.

Comment thread logger.go Outdated
case http.MethodDelete:
return red
case "PATCH":
case http.Patch:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http.MethodPatch?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. typo!

@appleboy appleboy added this to the 1.6 milestone Nov 28, 2019
@codecov

codecov Bot commented Nov 28, 2019

Copy link
Copy Markdown

Codecov Report

Merging #2155 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2155   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          40       40           
  Lines        2240     2240           
=======================================
  Hits         2209     2209           
  Misses         16       16           
  Partials       15       15
Impacted Files Coverage Δ
binding/binding.go 100% <100%> (ø) ⬆️
routergroup.go 100% <100%> (ø) ⬆️
gin.go 98.29% <100%> (ø) ⬆️
logger.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 352d69c...90e86af. Read the comment docs.

@thinkerou thinkerou merged commit d5f12ac into gin-gonic:master Nov 28, 2019
ThomasObenaus pushed a commit to ThomasObenaus/gin that referenced this pull request Feb 19, 2020
* use http method constant

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants