Drop .NET Framework and target .NET 8 on all platforms#1418
Draft
mjcheetham wants to merge 4 commits intogit-ecosystem:mainfrom
Draft
Drop .NET Framework and target .NET 8 on all platforms#1418mjcheetham wants to merge 4 commits intogit-ecosystem:mainfrom
mjcheetham wants to merge 4 commits intogit-ecosystem:mainfrom
Conversation
b8d9f42 to
3f46ba1
Compare
3f46ba1 to
6b9f9d4
Compare
ldennington
approved these changes
Sep 21, 2023
| <GenerateWindowsAppManifest Condition="'$(GenerateWindowsAppManifest)' == '' AND '$(OSPlatform)' == 'windows' AND '$(_IsExeProject)' == 'true'">true</GenerateWindowsAppManifest> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup Condition = "'$(TargetFramework)' == 'net472'"> |
Contributor
There was a problem hiding this comment.
Glad to be getting rid of this!
6b9f9d4 to
47072be
Compare
hickford
approved these changes
Oct 25, 2023
Contributor
|
@mjcheetham Any plan to return to this? |
Contributor
|
@mjcheetham Might you have time to look at this again? |
Contributor
Author
Hey @hickford, we are still planning to update to .NET 8 on Mac and Linux, but as to Windows and dropping .NET Framework we're a little stuck right now because of a courtesy to Visual Studio (that bundle the same GCM version across all their versions) who need Windows 8.x support until.. 2029... 😢 I plan to reach out to them and find a way forward. |
Contributor
Author
|
In the meantime, here's the .NET 8 PR for Mac and Linux: #1579 |
47072be to
90c01b6
Compare
Annotate any OS or platform specific code with the new (Un)SupportedOSPlatform(Guard) attributes and update various platform util methods to use the OperatingSystem.Is<platform> methods. This will help ensure we're not missing any OS checks in the future. For test projects we ignore these warnings since we're using skipping Xunit tests that are not applicable for the current platform already, making these warnings just noise.
90c01b6 to
2b8ecb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: #1417Drop .NET Framework as the target framework on Windows in favour of .NET 8. Also update our Mac and Linux builds to .NET 8 from .NET 7. .NET 8 is an LTS release that is currently in a release candidate, which has a "go live" licence, and is due to GA in November 2023.
Now that we are targeting .NET 8 on all platforms we can drop all the .NET Framework specific code that we've been carrying. We also annotate all OS-specific code with the various attributes like
[SupportedOSPlatform]to silence warnings and more importantly guard against accidentally using such code on the wrong platform (like in #1146).