Thanks to visit codestin.com
Credit goes to github.com

Skip to content

git-lfs: add config for more efficent filter-process protocol#133

Merged
dscho merged 1 commit into
git-for-windows:masterfrom
larsxschneider:lfs-filter
Feb 26, 2017
Merged

git-lfs: add config for more efficent filter-process protocol#133
dscho merged 1 commit into
git-for-windows:masterfrom
larsxschneider:lfs-filter

Conversation

@larsxschneider

Copy link
Copy Markdown
Member

The same config is set via the git lfs install command:
https://github.com/git-lfs/git-lfs/blob/e029224251e2d8b134ee92f3cc00e001fdcbfb40/lfs/setup.go#L32-L35

However, I wonder if should rather use git lfs install --system ?

--

This change is not tested. I just noticed the file and thought I could update it. I am pretty sure it works, though...

/cc @shiftkey

@shiftkey

shiftkey commented Feb 25, 2017

Copy link
Copy Markdown
Contributor

However, I wonder if should rather use git lfs install --system?

At the time I put together the original PR I'm pretty sure --system wasn't available #110 (comment). So I'm 👍 to using that here if it's now available.

@dscho

dscho commented Feb 26, 2017

Copy link
Copy Markdown
Member

The problem is that git-lfs may not be installed when git-extra's post-install script is run... so I think this PR is the best we can do.

Thanks for the contribution!

@dscho dscho merged commit e5d0f10 into git-for-windows:master Feb 26, 2017
@dscho

dscho commented Feb 26, 2017

Copy link
Copy Markdown
Member

whoops, forget my comment about git-lfs not being installed... I misread, and thought that this commit is about git-extra...

in any case, let's keep this as is for the moment, as it is not obvious what other changes git lfs install may want to make in the future.

@dscho

dscho commented Feb 26, 2017

Copy link
Copy Markdown
Member

@larsxschneider do you want a 1.5.6-2 to be uploaded to Pacman?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants