Thanks to visit codestin.com
Credit goes to github.com

Skip to content

push with ambiguous branch fails#1079

Closed
technoweenie wants to merge 1 commit into
masterfrom
push-with-ambiguous-branch
Closed

push with ambiguous branch fails#1079
technoweenie wants to merge 1 commit into
masterfrom
push-with-ambiguous-branch

Conversation

@technoweenie

@technoweenie technoweenie commented Mar 17, 2016

Copy link
Copy Markdown
Contributor

The scanner code doesn't handle git errors at all. I would expect this git lfs push command to fail, but it just returns successfully with no output. The problem is that the rev-list call is erroring, and git lfs is just rolling with it.

    + git lfs push --dry-run origin ambiguous-branch-name
    + tee push.log
    + echo 'actual git command:'
    + git rev-list --objects ambiguous-branch-name --not --remotes=origin
    fatal: ambiguous argument 'ambiguous-branch-name': both revision and filename
    Use '--' to separate paths from revisions, like this:
    'git <command> [<revision>...] -- [<file>...]'

@technoweenie technoweenie force-pushed the push-with-ambiguous-branch branch from c3297cc to 544a468 Compare March 17, 2016 15:28
@epriestley

epriestley commented Mar 19, 2016

Copy link
Copy Markdown

Oh -- I missed this, but #1096 is likely a fix for this, and presumably #1056 is the root issue.

@epriestley

epriestley commented Mar 19, 2016

Copy link
Copy Markdown

(Although those just correct the command, rather than detecting/handling errors.)

@epriestley epriestley mentioned this pull request Mar 21, 2016
Closed
@sinbad

sinbad commented Apr 1, 2016

Copy link
Copy Markdown
Contributor

Closing as addressed in #1118 now.

@sinbad sinbad closed this Apr 1, 2016
@technoweenie technoweenie deleted the push-with-ambiguous-branch branch April 6, 2016 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@technoweenie @epriestley @sinbad