Touch tracked files that are already added to git#1104
Merged
Conversation
This makes them appear as modified in 'git status' which indicates they need to be re-committed to be moved into LFS if already in git. See #1057
| line := scanner.Text() | ||
| ret = append(ret, strings.TrimSpace(line)) | ||
| } | ||
| return ret, nil |
Contributor
There was a problem hiding this comment.
I think this should wait for the command to finish before returning.
Contributor
|
Looks great 👍. I updated |
Contributor
Author
Doh, thanks for catching that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1057
If a file is already tracked in git when it's added to git-lfs tracking, that file is now 'touched' (
mtime/atimefile attributes updated) to ensure that it appears as modified ingit statusalong with the.gitattributesand therefore prompts the user to re-commit it. Without doing this git doesn't detect that the index is dirty for this file and the user could commit.gitattributesbut with the file content remaining as non-LFS, which can cause problems when checking out this commit in future. Checking out this commit will forever after show the file as modified in the working copy becausesmudgewill not have LFS data to checkout from even though.gitattributessays it should have, andcleanwill show a diff.