Fix problems with user prompts in git lfs clone#1185
Merged
Conversation
Stop using the psuedo-tty & pass through streams directly. Getting pty to work with stdin was too difficult, even when it worked passwords were displayed on the terminal which is no good. We no longer need to filter the stderr for known warnings; Git 2.8 is now released which deals with them and for Git 2.7 and below we can fall back on `cat` instead of a blank filter; it's slightly slower but eliminates the problem more simply.
Contributor
|
🤘 I'm glad that stderr handling code is gone. Looked fragile :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1159
Stop using the psuedo-tty & pass through streams directly. Getting pty to work with stdin was too difficult, even when it worked passwords were displayed on the terminal which is no good. We no longer need to filter the stderr for known warnings; Git 2.8 is now released which deals with them and for Git 2.7 and below we can fall back on
catinstead of a blank filter; it's slightly slower but eliminates the problem more simply. We used to do this for git < 2.2 anyway which didn't support blank filters at all.