Applied same -ldflags -X name value -> name=value fix as in a62e510f.#1193
Merged
technoweenie merged 1 commit intoMay 4, 2016
Merged
Conversation
Squashes script/run warning: link: warning: option -X github.com/github/git-lfs/lfs.GitCommit 54c5efa may not work in future releases; use -X github.com/github/git-lfs/lfs.GitCommit=54c5efa
Contributor
|
IIRC, this breaks on older versions of Go. However, I see that Go 1.7 is nearing feature freeze, so we may want to lock LFS to Go 1.6+. |
Contributor
Author
|
Right, I think this change was made in the main build already for the Go 1.5 change, a62e510 . So if it doesn't work for < 1.5 it should show-up already? I confess I am using 1.6. I think moving to at least Go >= 1.5, or 1.6 if the vendor imports are reworked, has been discussed in another issue. |
Contributor
|
Turns out I already had this conversation, and decided supporting whatever old Go version wasn't worth it. a62e510 I just checked in Go 1.3-1.6. It works on all of them, but only prints the commit in Go 1.5+. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Squashes script/run warning:
link: warning: option -X github.com/github/git-lfs/lfs.GitCommit 54c5efa may not work in future releases; use -X github.com/github/git-lfs/lfs.GitCommit=54c5efa