Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add missing config details to env command#1217

Merged
sinbad merged 1 commit into
masterfrom
env-print-more
May 12, 2016
Merged

Add missing config details to env command#1217
sinbad merged 1 commit into
masterfrom
env-print-more

Conversation

@sinbad

@sinbad sinbad commented May 12, 2016

Copy link
Copy Markdown
Contributor

Adds all Fetch/Prune config details to the env command, as well as extensions which weren't reported.

@sinbad sinbad added the review label May 12, 2016
@sinbad

sinbad commented May 12, 2016

Copy link
Copy Markdown
Contributor Author

Oh also exposes the Access settings since I thought that was useful.

@technoweenie

Copy link
Copy Markdown
Contributor

So the roadmap vaguely mentions "add all lfs.* git config keys to git lfs env output". I'd love some automated way to do this, so we don't have to update it every time we add a new property.

However, I think this PR shows why the manual approach is good:

  1. We output the value that Git LFS is using. It may come from an env var, a git config value, or implicit default in the tool.
  2. The tests have to be updated with all the new properties. I'd be open to another solution to this if you have any thoughts though. Definitely not a blocker for this PR.

🚢

@sinbad

sinbad commented May 12, 2016

Copy link
Copy Markdown
Contributor Author

Although we could dump the contents of the git config fairly easily, it doesn't totally reflect how we use the values internally (defaults, derived values) so I kinda like the hand crafted approach. Could maybe use reflection to automate if it became a problem? Otherwise I think this is ok for now.

@sinbad sinbad merged commit 1e15699 into master May 12, 2016
@sinbad sinbad deleted the env-print-more branch May 12, 2016 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants