Thanks to visit codestin.com
Credit goes to github.com

Skip to content

re-enable push and pre-push dry-run flags#1673

Closed
technoweenie wants to merge 1 commit into
masterfrom
push-dry-run
Closed

re-enable push and pre-push dry-run flags#1673
technoweenie wants to merge 1 commit into
masterfrom
push-dry-run

Conversation

@technoweenie

Copy link
Copy Markdown
Contributor

My push/pre-push refactoring (#1128) inadvertently broke dry runs of these commands.

@ttaylorr ttaylorr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Wondering if we should do a refute_server_object in some of the integration tests like this one?

@technoweenie

Copy link
Copy Markdown
Contributor Author

Doh, setting DryRun in

func newUploadContext(dryRun bool) *uploadContext {
return &uploadContext{
DryRun: dryRun,
. False alarm, people.

@technoweenie technoweenie deleted the push-dry-run branch November 17, 2016 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants