Fix "foo is outside repository" error when "git lfs track" in a symlinked dir#818
Merged
Merged
Conversation
f6fc7c1 to
8af895c
Compare
Contributor
|
Today I encounter the same issue, but has slight different solutions, see #822 |
Contributor
|
Thanks for the patch! |
technoweenie
added a commit
that referenced
this pull request
Nov 16, 2015
Fix "foo is outside repository" error when "git lfs track" in a symlinked dir
This was referenced Nov 16, 2015
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reproduce, run this with an unmatched git lfs:
This was accidentally caused by the move to use
git rev-parse --top-levelto find the working dir. While more reliable than previous manual methods, git also silently resolves symlinks in the returned path, meaning thatlfs.LocalWorkingDiris always the real path and not the symlink. This causesHasPrefixtests to fail unless you also check the resolved symlink version.