Thanks to visit codestin.com
Credit goes to github.com

Skip to content

run tests on Travis-CI against default Git and latest Git#990

Merged
technoweenie merged 3 commits into
git-lfs:masterfrom
larsxschneider:travis
Feb 11, 2016
Merged

run tests on Travis-CI against default Git and latest Git#990
technoweenie merged 3 commits into
git-lfs:masterfrom
larsxschneider:travis

Conversation

@larsxschneider

@larsxschneider larsxschneider commented Feb 9, 2016

Copy link
Copy Markdown
Member

Run Git-LFS tests against the Travis-CI default Git version and the
latest available Git version on the respective platform.

The default Git version is currently 1.8.5.6 on Ubuntu and 1.9.3 on OSX.

@larsxschneider larsxschneider mentioned this pull request Feb 9, 2016
Merged
@technoweenie

technoweenie commented Feb 10, 2016

Copy link
Copy Markdown
Contributor

Cool, looks like this may have caught a bug on the mac build with the latest version of git:

test: track outside git repo ...                                   FAILED
-- stdout --
    Tracking *.foo
    Initialized empty Git repository in /Users/travis/gopath/src/github.com/github/git-lfs/tmp/test-track.sh-16301/track-outside/.git/
    Tracking *.file
    Tracking ../*.foo
-- stderr --
    +set -e
    +git lfs track '*.foo'
    +'[' -n '' ']'
    +git init track-outside
    +cd track-outside
    +git lfs track '*.file'
    +git lfs track '../*.foo'
    +exit 1
    +end_test
    +test_status=1
    +set +x -e
-- git trace --
   18:23:49.229193 git.c:561               trace: exec: 'git-lfs' 'track' '*.foo'
   18:23:49.237118 run-command.c:343       trace: run_command: 'git-lfs' 'track' '*.foo'
   18:23:49.807455 git.c:348               trace: built-in: git 'init' 'track-outside'
   18:23:50.007477 git.c:561               trace: exec: 'git-lfs' 'track' '*.file'
   18:23:50.013329 run-command.c:343       trace: run_command: 'git-lfs' 'track' '*.file'
   18:23:50.061033 git.c:561               trace: exec: 'git-lfs' 'track' '../*.foo'
   18:23:50.061700 run-command.c:343       trace: run_command: 'git-lfs' 'track' '../*.foo'

Lars Schneider added 3 commits February 11, 2016 09:53
travis-ci: run tests against default Git and latest Git
bc9ed62 
Run Git-LFS tests against the Travis-CI default Git version and the
latest available Git version on the respective platform.

The default Git version is currently 1.8.5.6 on Ubuntu and 1.9.3 on OSX.
travis-ci: use multi line 'before_install' phase to improve readability
ed2b9f6
travis-ci: declare global variable in 'env' section
dc358a0
@larsxschneider

larsxschneider commented Feb 11, 2016

Copy link
Copy Markdown
Member Author

There is no bug in your code ... there was a bug in my patch 😞
I overwrote the path fixing before_install step in the matrix section. Now it's fixed :-)

BTW:
Are you OK with rebasing PR's (like I did here) or do you prefer to see how the bug was fixed in a separate commit?

@technoweenie

technoweenie commented Feb 11, 2016

Copy link
Copy Markdown
Contributor

Ha, nice :)

I don't rebase personally, but I have no problem if others do.

technoweenie added a commit that referenced this pull request Feb 11, 2016
@technoweenie
Merge pull request #990 from larsxschneider/travis
05aa87d 
run tests on Travis-CI against default Git and latest Git
@technoweenie technoweenie merged commit 05aa87d into git-lfs:master Feb 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@larsxschneider @technoweenie