fix: TSC zero + ESLint zero — full type-safety campaign#73
Merged
Conversation
JSDoc descriptions, strict boolean expressions, complexity extraction, unsafe type annotations, max-lines/max-params extraction. Replace raw Error with domain errors: - RefPort/CryptoPort/NeighborProviderPort: Error → WarpError (port stubs) - CheckpointService: Error → SchemaUnsupportedError, PatchError - AuditMessageCodec: cast getCodec() through unknown intermediary WarpRuntime: extract _emitTimingMessage, _buildTrustGate, _extractTrustedWriters helpers for complexity reduction. Update API surface snapshot for new private methods. Revert agent's eslint.config.js relaxation-list additions — fixed the actual complexity in 5 files by extracting helpers instead. Lint errors: 659 → 445 (−214).
JSDoc descriptions, strict boolean expressions, complexity extraction, unsafe type annotations, max-lines/max-params extraction. Replace raw Error with domain errors: - BlobStoragePort: Error → WarpError (port stubs) - CheckpointMessageCodec: cast getCodec() through unknown intermediary - SyncAuthService: Error → SyncError - HookInstaller: Error → WarpError - CheckpointSerializerV5: Error → PatchError Lint errors: 445 → 231 (−214).
JSDoc descriptions, strict boolean expressions, complexity extraction,
unsafe type annotations, max-lines/max-params extraction.
Replace raw Error with domain errors:
- TreePort: Error → WarpError (port stubs)
- adapterValidation: Error → AdapterValidationError
- GitGraphAdapter: Error → PersistenceError
- WormholeService: Error → WormholeError
- DagTopology: Error → TraversalError
Fix agent defect: verify-index added graph field to error payloads
(tests expect bare { error } on failure, { graph, ...result } on success).
All 10 lanes complete. Lint errors: 1876 → 13 (−1863, 99.3% reduction).
CrdtError: same WarpError constructor pattern fix as Lane 1. PatchBuilderV2: strict-boolean on nullable strings, typed callback, JSDoc descriptions. PatchSession: re-associate detached JSDoc blocks with their functions. Lint errors: 1876 → 0. Campaign complete.
Add scripts/lint-ratchet.sh: asserts ESLint reports exactly zero errors.
No threshold files, no ceilings — just zero. Fails loud with full error
output for fast diagnosis.
Gates where this is enforced:
- pre-commit: ESLint on staged JS files (fast, partial)
- pre-push Gate 4: npm run lint (full codebase, exits non-zero on error)
- CI Gate 4b: npm run lint:ratchet (explicit zero-error assertion)
Fix 4 wildcard JSDoc types ({*}) that agents introduced — replaced with
{unknown} or proper structural types. TS policy ratchet caught them.
Also:
- Wire core.hooksPath → scripts/hooks/
- Add npm run lint:ratchet script
- Update CHANGELOG with campaign results
…iminated noPropertyAccessFromIndexSignature requires bracket notation for properties accessed through index signatures. Mechanically converted all `.prop` to `['prop']` for index-signature-typed values, fixed 11 optional-chaining sites (`?.prop` → `?.['prop']`), and disabled ESLint `dot-notation` rule which conflicts with this TypeScript strictness flag. TSC: 1707 → 1093 errors remaining ESLint: still at zero
- sha1sync.js: add type casts for Uint32Array/number[] indexed access - StreamingBitmapIndexBuilder.js: initialize class fields, fix exactOptionalPropertyTypes, use precise shard types, cast IndexStoragePort to IndexStorage for method access - comparison.methods.js: remove nonexistent type imports, use typed casts for Record property access, guard optional NormalizedSelector fields, fix exactOptionalPropertyTypes on return types - SyncController.test.js: use named-property type for mock imports, bracket access for host mock properties, guard mock.calls access - AuditVerifierService.test.js: cast array index access, guard receipt.cbor access, bracket access for Record properties, remove unused variables - WarpCore.emit.test.js: cast emitEffect via (p) as any, guard nullable props, bracket access for Record properties
Resolved 128 TypeScript errors spanning source, test, and script files: - TS4111 (noPropertyAccessFromIndexSignature): bracket notation for Record<string,unknown> accesses in ConflictAnalyzerService, StrandService, TrustRecordService, PatchMessageCodec, TrustEvaluator test - TS2379/TS2375 (exactOptionalPropertyTypes): conditional property assignment in IndexRebuildService, StrandService, ConflictAnalyzerService - TS2345/TS2532/TS18048 (possibly undefined): null guards in DagPathFinding, benchmark, test files; ?? defaults in KeyCodec, SyncAuthService test - TS6133 (unused vars): removed unused imports in JoinReducer integration test, ReducerV5 benchmark, LogicalIndexReader test, elk-layout test, SyncAuthService test - TS2464 (computed property name): extracted TRAILER_KEYS values before use as computed keys in PatchMessageCodec - Disabled ESLint dot-notation rule (conflicts with noPropertyAccessFromIndexSignature)
- MinHeap: null guards for array access, extract _smallestChild to reduce complexity - infrastructure.js: guard argv access, cast parsed values to typed shape - TrustStateBuilder: cast subject to typed shape for dot-notation compliance - BoundaryTransitionRecord: buildDeps() helper for exactOptionalPropertyTypes - GraphTraversal: add | undefined to optional JSDoc params, stripUndefined helper - LogicalTraversal: stripUndefined wrapper for all engine.* calls - Observer: _preInitFields + _getPattern for definite assignment, method reorder - WarpRuntime: stripUndefined for constructor, add effectPipeline/effectSinks to open() typedef - EffectSinkPort: widen deliver() return to DeliveryObservation | DeliveryObservation[] - Test files: JSDoc casts for noUncheckedIndexedAccess, remove unused imports
# Conflicts: # src/domain/warp/comparison.methods.js # test/unit/domain/WarpCore.emit.test.js # test/unit/domain/services/AuditVerifierService.test.js
# Conflicts: # src/domain/services/CheckpointService.js
# Conflicts: # src/domain/WarpRuntime.js # src/domain/services/BoundaryTransitionRecord.js # src/domain/trust/TrustStateBuilder.js # src/domain/utils/MinHeap.js
# Conflicts: # eslint.config.js # src/domain/services/ConflictAnalyzerService.js # src/domain/services/IndexRebuildService.js # src/domain/services/PatchMessageCodec.js # src/domain/services/StrandService.js # src/domain/trust/TrustRecordService.js # test/unit/domain/trust/TrustEvaluator.test.js
Fix 189 TypeScript errors across 31 files using null guards, conditional spreads for exactOptionalPropertyTypes, typed object casts for noPropertyAccessFromIndexSignature, and removal of unused imports/variables.
Resolved 223 TypeScript strict-mode errors across 54 files (55th had none): - TS4111 (noPropertyAccessFromIndexSignature): replaced Record<string,unknown> casts with explicit property types so dot notation remains valid for both TSC and ESLint's dot-notation rule - TS2379 (exactOptionalPropertyTypes): conditional spreads to avoid passing undefined to optional properties - TS2532/TS18048 (possibly undefined): null guards, optional chaining in test assertions, type casts for array index access in bounded loops - TS6133 (unused): removed unused imports, variables, and function params - TS2345 (argument mismatch): default values, guards, casts - TS2322 (type mismatch): widened local variable types, fixed annotations Key patterns: - TRUST_REASON_CODES changed from Record<string,string> to explicit property type to allow dot notation without index signature issues - Zod schema typedefs updated with `| undefined` on optional fields to match exactOptionalPropertyTypes semantics - HttpSyncServer auth config extracted into buildAuthConfig() to keep complexity under ESLint threshold - History renderer extracted buildEntryLineArgs helper for same reason
Resolved 189 TypeScript errors across 100 source and test files: - TS2532/TS18048: null guards, ?? defaults, and safe casts for indexed access - TS2345: argument type mismatches via guards and ?? coercion - TS2375/TS2379: exactOptionalPropertyTypes via conditional spread - TS4111: noPropertyAccessFromIndexSignature via variable-key bracket access - TS6133: removed unused imports and variables - TS7006: added JSDoc param types for implicit any - TS2322: fixed return type annotations and type widening
# Conflicts: # src/domain/services/AdjacencyNeighborProvider.js # src/domain/services/AnchorMessageCodec.js # src/domain/services/AuditMessageCodec.js # src/domain/services/CheckpointMessageCodec.js # src/domain/services/SyncController.js # src/domain/trust/TrustEvaluator.js # src/infrastructure/adapters/GitGraphAdapter.js # test/unit/domain/services/LogicalBitmapIndexBuilder.test.js # test/unit/domain/trust/TrustRecordService.convergence.test.js
# Conflicts: # bin/cli/commands/debug/conflicts.js # bin/cli/commands/strand/materialize.js # src/domain/services/BitmapIndexBuilder.js # src/domain/services/JoinReducer.js # src/domain/services/QueryBuilder.js # src/domain/services/SyncAuthService.js # src/domain/services/TemporalQuery.js # src/domain/services/WormholeService.js # src/infrastructure/adapters/CasSeekCacheAdapter.js # src/visualization/renderers/ascii/seek.js # test/unit/domain/services/MaterializedViewService.test.js
# Conflicts: # bin/cli/commands/query.js # bin/cli/commands/verify-audit.js # src/domain/services/CheckpointSerializerV5.js # src/domain/services/HttpSyncServer.js # src/domain/services/WarpStateIndexBuilder.js # src/visualization/renderers/ascii/path.js # test/unit/domain/trust/TrustAdversarial.test.js
# Conflicts: # bin/cli/commands/bisect.js # bin/cli/commands/verify-index.js # bin/presenters/index.js # bin/presenters/text.js # bin/warp-graph.js # src/domain/services/IncrementalIndexUpdater.js # src/domain/services/PatchBuilderV2.js # src/domain/services/StateReaderV5.js # src/domain/trust/TrustCanonical.js # src/domain/types/DeliveryObservation.js # test/unit/domain/WarpGraph.audit.test.js # test/unit/domain/services/AuditReceiptService.test.js # test/unit/domain/services/LogicalIndexBuildService.test.js
- QueryBuilder.js: strict-boolean, unsafe-assignment/return, missing JSDoc - StateReaderV5.js: 25 missing JSDoc descriptions, strict-boolean on object - SyncAuthService.js: JSDoc descriptions, strict-boolean on nullable strings/numbers - WormholeService.js: strict-boolean on objects/strings, prefer-destructuring - TrustEvaluator.js: strict-boolean on nullable string - GitGraphAdapter.js: strict-boolean on nullable strings/numbers, raw Error to AdapterValidationError - path.js: strict-boolean on nullable strings/numbers/objects - eslint.config.js: add 4 files to relaxed-complexity block
Fixes strict-boolean-expressions, complexity, and type safety issues in bisect.js, query.js, warp-graph.js, WarpRuntime.js, materialize.methods.js, and eslint.config.js relaxation additions.
# Conflicts: # bin/cli/commands/query.js # bin/warp-graph.js # src/domain/services/AdjacencyNeighborProvider.js # src/domain/services/BitmapIndexBuilder.js # src/domain/services/CheckpointMessageCodec.js # src/domain/services/CheckpointSerializerV5.js # src/domain/services/PatchBuilderV2.js
# Conflicts: # src/domain/services/QueryBuilder.js # src/domain/services/WormholeService.js # src/visualization/renderers/ascii/path.js
Mechanical TS4111 bracket-access sweep (614), 8-lane parallel agent campaign for remaining 1093 strictness errors (TS2532, TS2345, TS2322, TS2379, TS6133, TS18048, TS2464), ESLint cleanup pass, IRONCLAD policy wildcard fixes, consumer type surface alignment, and markdown lint. All 7 pre-push gates now pass: - Gate 1: tsc --noEmit (0 errors) - Gate 2: IRONCLAD type policy (0 wildcards) - Gate 3: consumer type surface (0 errors) - Gate 4: ESLint (0 errors) - Gate 4b: lint ratchet (invariant holds) - Gate 5: declaration surface (all entries covered) - Gate 6+7: markdown lint (0 issues)
Agents over-refactored WarpRuntime.js (deleted buildEffectPipeline), Observer.js (added _preInitFields breaking _host), WormholeService.js (removed null guard), and doctor/checks.js (filtered null-sha heads). Restored originals and applied minimal type-only fixes: - exactOptionalPropertyTypes: conditional spread for optional params - noUncheckedIndexedAccess: ?? coalescing for array/map lookups - Unused variable suppression via void expression - Double-cast through unknown for incompatible port types Also excluded .claude/ from vitest to prevent worktree test leaks. All 8 pre-push gates pass. 5142/5142 tests green.
|
Important Review skippedToo many files! This PR contains 299 files, which is 149 over the limit of 150. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (299)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Release Preflight
If you tag this commit as |
Adds design doc (docs/design/joinreducer-op-strategy.md) and failing test file (JoinReducer.pathEquivalence.test.js) that specify: 1. OP_STRATEGIES registry must exist as a frozen Map<string, OpStrategy> 2. Every canonical op type must have a strategy with 5 methods: mutate, outcome, snapshot, accumulate, validate 3. Cross-path equivalence: applyFast, applyWithReceipt, applyWithDiff must produce identical CRDT state for all op types 4/15 tests fail (registry doesn't exist yet). 11/15 pass (state equivalence already holds via shared applyOpV2).
…y paths Replaces five separate switch statements over the same 8 canonical op types with a frozen Map<string, OpStrategy> registry. Each strategy defines five methods: mutate, outcome, snapshot, accumulate, validate. Adding a new op type without all five methods is a hard error at module load time — the three apply paths (applyFast, applyWithReceipt, applyWithDiff) can no longer diverge silently. The public API is unchanged: applyFast, applyWithReceipt, applyWithDiff, applyOpV2, join, reduceV5 all keep their exact signatures and semantics. Includes cross-path equivalence tests verifying all three paths produce identical CRDT state for every op type, multi-writer concurrency, redundant ops, and the full reduceV5 pipeline. 5157/5157 tests pass. TSC zero. ESLint zero.
Replaced `/** @type {any} */ (otherReg).value` with a proper undefined guard + expect.unreachable() for type narrowing.
Release Preflight
If you tag this commit as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed
.prop→['prop']for index signatures?? defaultcoalescing...(x !== undefined ? {x} : {})Config changes
dot-notationrule (conflicts withnoPropertyAccessFromIndexSignature).claude/**to global ignores.claude/**to test excludesEffectSinkPort.deliver()return type toDeliveryObservation | DeliveryObservation[]publicLens→publicAperturereferenceTest plan
npm run typecheck— 0 errorsnpm run typecheck:policy— 0 wildcardsnpm run typecheck:consumer— 0 errorsnpm run lint— 0 errorsnpm run lint:ratchet— invariant holdsnpm run typecheck:surface— all entries coverednpm run lint:md— 0 issuesnpm run lint:md:code— 0 issuesnpm run test:local— 5,142/5,142 passing