fix: add constructor validation for required dependencies

- CborPatchJournalAdapter: validate codec, blobPort - CborCheckpointStoreAdapter: validate codec, blobPort - CborEncodeTransform: validate codec - CborDecodeTransform: validate codec - GitBlobWriteTransform: validate blobPort - TreeAssemblerSink: validate treePort - IndexShardEncodeTransform: validate codec - Sink.consume(): validate source param - PatchBuilderV2: replace generic Error with PersistenceError (E_MISSING_JOURNAL) - CheckpointStorePort: remove misleading treeOid from CheckpointWriteResult
git-stunts · flyingrobots · Apr 5, 2026 · Apr 4, 2026 · Apr 4, 2026 · Apr 4, 2026
commit bf9eccfc3775d3ec0f8db3be214d6ce85d9592ff
diff --git a/src/domain/WarpRuntime.js b/src/domain/WarpRuntime.js
@@ -575,11 +575,13 @@ export default class WarpRuntime {
       });
     }
 
-    // Auto-construct StateHashService from codec + crypto
-    graph._stateHashService = new StateHashService({
-      codec: graph._codec,
-      crypto: graph._crypto,
-    });
+    // Auto-construct StateHashService from codec + crypto (only when crypto is available)
+    if (graph._crypto) {
+      graph._stateHashService = new StateHashService({
+        codec: graph._codec,
+        crypto: graph._crypto,
+      });
+    }
 
     // Validate migration boundary
     await graph._validateMigrationBoundary();

diff --git a/src/domain/services/PatchBuilderV2.js b/src/domain/services/PatchBuilderV2.js
@@ -39,6 +39,7 @@ import WriterError from '../errors/WriterError.js';
 import { isStreamingInput, normalizeToAsyncIterable } from '../utils/streamUtils.js';
 import { canonicalStringify } from '../utils/canonicalStringify.js';
 import PatchError from '../errors/PatchError.js';
+import PersistenceError from '../errors/PersistenceError.js';
 
 /**
  * Inspects materialized state for edges and properties attached to a node.
@@ -983,7 +984,7 @@ export class PatchBuilderV2 {
 
       // 6. Persist patch via PatchJournalPort (adapter owns encoding).
       if (this._patchJournal === null || this._patchJournal === undefined) {
-        throw new Error('patchJournal is required for committing patches');
+        throw new PersistenceError('patchJournal is required for committing patches', 'E_MISSING_JOURNAL');
       }
       const patchBlobOid = await this._patchJournal.writePatch(patch);
 

diff --git a/src/domain/services/index/LogicalIndexBuildService.js b/src/domain/services/index/LogicalIndexBuildService.js
@@ -64,17 +64,21 @@ export default class LogicalIndexBuildService {
   buildStream(state, options = {}) {
     const { indexBuilder, propBuilder } = this._populateBuilders(state, options);
 
+    // Collect shards once — generators yield fresh iterators on each call,
+    // so calling yieldShards() twice would re-iterate all bitmaps.
+    const indexShards = [...indexBuilder.yieldShards()];
+    const receiptShard = indexShards.find((s) => s instanceof ReceiptShard);
+    if (!receiptShard) {
+      throw new Error('LogicalIndexBuildService: index builder did not emit a ReceiptShard');
+    }
+
     // Merge both builders' shard streams
     const stream = WarpStream.mux(
-      WarpStream.from(indexBuilder.yieldShards()),
+      WarpStream.from(indexShards),
       WarpStream.from(propBuilder.yieldShards()),
     );
 
-    // Extract receipt from the index builder (it's deterministic, no need to decode)
-    const shards = [...indexBuilder.yieldShards()];
-    const receiptShard = /** @type {ReceiptShard} */ (shards.find((s) => s instanceof ReceiptShard));
-
-    return { stream, receipt: receiptShard };
+    return { stream, receipt: /** @type {ReceiptShard} */ (receiptShard) };
   }
 
   /**

diff --git a/src/domain/services/state/StateHashService.js b/src/domain/services/state/StateHashService.js
@@ -1,4 +1,5 @@
 import { projectStateV5 } from './StateSerializerV5.js';
+import WarpError from '../../errors/WarpError.js';
 
 /**
  * Computes canonical state hashes for verification, comparison,
@@ -21,6 +22,12 @@ export default class StateHashService {
    * }} deps
    */
   constructor({ codec, crypto }) {
+    if (codec === undefined || codec === null) {
+      throw new WarpError('StateHashService requires a codec', 'E_MISSING_DEPENDENCY');
+    }
+    if (crypto === undefined || crypto === null) {
+      throw new WarpError('StateHashService requires a crypto adapter', 'E_MISSING_DEPENDENCY');
+    }
     /** @type {import('../../../ports/CodecPort.js').default} */
     this._codec = codec;
     /** @type {import('../../../ports/CryptoPort.js').default} */

diff --git a/src/domain/stream/Sink.js b/src/domain/stream/Sink.js
@@ -25,6 +25,9 @@ export default class Sink {
    * @returns {Promise<R>} The accumulated result
    */
   async consume(source) {
+    if (source === null || source === undefined) {
+      throw new WarpError('Sink.consume() requires a source', 'E_INVALID_SOURCE');
+    }
     for await (const item of source) {
       await this._accept(item);
     }

diff --git a/src/infrastructure/adapters/CborCheckpointStoreAdapter.js b/src/infrastructure/adapters/CborCheckpointStoreAdapter.js
@@ -26,6 +26,12 @@ export class CborCheckpointStoreAdapter extends CheckpointStorePort {
    */
   constructor({ codec, blobPort }) {
     super();
+    if (codec === null || codec === undefined) {
+      throw new WarpError('CborCheckpointStoreAdapter requires a codec', 'E_INVALID_DEPENDENCY');
+    }
+    if (blobPort === null || blobPort === undefined) {
+      throw new WarpError('CborCheckpointStoreAdapter requires a blobPort', 'E_INVALID_DEPENDENCY');
+    }
     /** @type {import('../../ports/CodecPort.js').default} */
     this._codec = codec;
     /** @type {import('../../ports/BlobPort.js').default} */
@@ -63,7 +69,6 @@ export class CborCheckpointStoreAdapter extends CheckpointStorePort {
 
     const oids = await Promise.all(writes);
     return {
-      treeOid: '', // Caller assembles tree (CheckpointService owns commit creation)
       stateBlobOid: oids[0],
       frontierBlobOid: oids[1],
       appliedVVBlobOid: oids[2],

diff --git a/src/infrastructure/adapters/CborDecodeTransform.js b/src/infrastructure/adapters/CborDecodeTransform.js
@@ -1,4 +1,5 @@
 import Transform from '../../domain/stream/Transform.js';
+import WarpError from '../../domain/errors/WarpError.js';
 
 /**
  * Stream transform that CBOR-decodes the value component of [path, bytes] entries.
@@ -16,6 +17,9 @@ export class CborDecodeTransform extends Transform {
    */
   constructor(codec) {
     super();
+    if (codec === null || codec === undefined) {
+      throw new WarpError('CborDecodeTransform requires a codec', 'E_INVALID_DEPENDENCY');
+    }
     /** @type {import('../../ports/CodecPort.js').default} */
     this._codec = codec;
   }

diff --git a/src/infrastructure/adapters/CborPatchJournalAdapter.js b/src/infrastructure/adapters/CborPatchJournalAdapter.js
@@ -31,6 +31,12 @@ export class CborPatchJournalAdapter extends PatchJournalPort {
    */
   constructor({ codec, blobPort, commitPort, patchBlobStorage }) {
     super();
+    if (codec === null || codec === undefined) {
+      throw new WarpError('CborPatchJournalAdapter requires a codec', 'E_INVALID_DEPENDENCY');
+    }
+    if (blobPort === null || blobPort === undefined) {
+      throw new WarpError('CborPatchJournalAdapter requires a blobPort', 'E_INVALID_DEPENDENCY');
+    }
     /** @type {import('../../ports/CodecPort.js').default} */
     this._codec = codec;
     /** @type {import('../../ports/BlobPort.js').default} */

diff --git a/src/infrastructure/adapters/GitBlobWriteTransform.js b/src/infrastructure/adapters/GitBlobWriteTransform.js
@@ -1,4 +1,5 @@
 import Transform from '../../domain/stream/Transform.js';
+import WarpError from '../../domain/errors/WarpError.js';
 
 /**
  * Stream transform that writes the bytes component of [path, bytes] entries
@@ -17,6 +18,9 @@ export class GitBlobWriteTransform extends Transform {
    */
   constructor(blobPort) {
     super();
+    if (blobPort === null || blobPort === undefined) {
+      throw new WarpError('GitBlobWriteTransform requires a blobPort', 'E_INVALID_DEPENDENCY');
+    }
     /** @type {import('../../ports/BlobPort.js').default} */
     this._blobPort = blobPort;
   }

diff --git a/src/infrastructure/adapters/IndexShardEncodeTransform.js b/src/infrastructure/adapters/IndexShardEncodeTransform.js
@@ -28,6 +28,9 @@ export class IndexShardEncodeTransform extends Transform {
    */
   constructor(codec) {
     super();
+    if (codec === null || codec === undefined) {
+      throw new WarpError('IndexShardEncodeTransform requires a codec', 'E_INVALID_DEPENDENCY');
+    }
     /** @type {import('../../ports/CodecPort.js').default} */
     this._codec = codec;
   }

diff --git a/src/infrastructure/adapters/TreeAssemblerSink.js b/src/infrastructure/adapters/TreeAssemblerSink.js
@@ -1,4 +1,5 @@
 import Sink from '../../domain/stream/Sink.js';
+import WarpError from '../../domain/errors/WarpError.js';
 
 /**
  * Stream sink that accumulates [path, oid] entries and assembles them
@@ -17,6 +18,9 @@ export class TreeAssemblerSink extends Sink {
    */
   constructor(treePort) {
     super();
+    if (treePort === null || treePort === undefined) {
+      throw new WarpError('TreeAssemblerSink requires a treePort', 'E_INVALID_DEPENDENCY');
+    }
     /** @type {import('../../ports/TreePort.js').default} */
     this._treePort = treePort;
     /** @type {string[]} mktree-formatted entries */

diff --git a/src/ports/CheckpointStorePort.js b/src/ports/CheckpointStorePort.js
@@ -12,7 +12,6 @@ import WarpError from '../domain/errors/WarpError.js';
 
 /**
  * @typedef {{
- *   treeOid: string,
  *   stateBlobOid: string,
  *   frontierBlobOid: string,
  *   appliedVVBlobOid: string,