This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Fix draft appearing after sucessful submit. #2027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain situations, the inline comment thread was refreshed before the `DeleteDraft(comment)` line in `PullRequestReviewCommentThreadViewModel.PostComment` was run, meaning that the draft would be displayed _after_ the comment was succesfully submitted. Work around this by deleting the draft before submitting the comment, and if we get an error re-insert the draft.
Codecov Report
@@ Coverage Diff @@
## master #2027 +/- ##
==========================================
- Coverage 40.72% 39.28% -1.45%
==========================================
Files 377 410 +33
Lines 16325 17585 +1260
Branches 2245 2435 +190
==========================================
+ Hits 6649 6908 +259
- Misses 9144 10120 +976
- Partials 532 557 +25
|
|
This LGTM 👍 |
jcansdale
approved these changes
Nov 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain situations, the inline comment thread was refreshed before the
DeleteDraft(comment)line inPullRequestReviewCommentThreadViewModel.PostCommentwas run, meaning that the draft would be displayed after the comment was succesfully submitted, causing a situation like this:Work around this by deleting the draft before submitting the comment, and if we get an error re-insert the draft.
Bonus fix: Don't save drafts of empty comments.