Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Modernizing and Implementing Autocompletebox #2158

Merged
merged 74 commits into from
Apr 10, 2019

Conversation

StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Jan 4, 2019

This pull request is the set of changes made to make AutoCompleteBox functional in our codebase

  • Using modern structures like Guard instead of Ensure
  • Removing the legacy cache system
  • Using GraphQL for querying data

Depends On

@StanleyGoldman StanleyGoldman changed the title [WIP] Modernizing Autocompletebox Modernizing and Implementing Autocompletebox Apr 8, 2019
@meaghanlewis
Copy link
Contributor

@StanleyGoldman would it be possible to also show pull requests in the autocomplete list in addition to issues?

@meaghanlewis
Copy link
Contributor

@StanleyGoldman this is working well! One thing that differs from dotcom is that you only seem to filter on open issues/PRs (filter = $"repo:{owner}/{name} is:open";) where dotcom shows all.

Copy link
Contributor

@meaghanlewis meaghanlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This functionality works well for me. 👍

@StanleyGoldman StanleyGoldman merged commit 0b5badb into autocompletebox Apr 10, 2019
@StanleyGoldman StanleyGoldman deleted the autocompletebox-fix branch April 10, 2019 21:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants