This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Use Visual Studio colors and styles for all dialogs #2261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing unused UI components.
|
Looks like I have some theming to fix:
|
This means we don't need to individualy style standard controls (e.g. with ThemedDialogListViewStyleKey).
Demove the default Label style (GitHubLabel).
It looks like PromptTextBox theming isn't currently working.
This will allows us to preview dialogs using Visual Studio colors/brushes.
In order for view to see ThemedDialogTextBoxStyleKey as StaticResource, ThemedDialogDefaultStylesKey must be imported into the View rather than the containing Window.
grokys
reviewed
Mar 8, 2019
src/GitHub.VisualStudio.UI/Views/Dialog/RepositoryCreationView.xaml
Outdated
Show resolved
Hide resolved
Don't create a dependency on which resource dictionaries have been merged.
I'm confused as to why this is nessesary!
Move default PromptTextBox and SecurePasswordBox into same ResourceDictionary as GitHubVsPromptTextBox.
|
Issue with spans and selected text?
|
|
Fix the list item background. It should look like this (circled). |
This was referenced Mar 26, 2019
Remove dependency on the VSColorTheme class.
StanleyGoldman
approved these changes
Apr 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2300
Migrate from using styles in
GitHub.UI(which were inherited from GitHub Desktop) to using a combination of native Visual Studio styles and styles inGitHub.VisualStudio.UI. The styles inGitHub.VisualStudio.UIcontain skins for custom GitHub controls and know about the Blue, Dark and Light Visual Studio themes.What this PR does
The following dialogs have been updated to use Visual Studio /
GitHub.VisualStudio.UIstyles:Allows previewing of views in designer with Visual Studio styles:
Other cleanup:
GitHub.UITo do
DarkthemeSign in)Fixes Pull Request filter text too dark on dark theme #1785
Done:
Here's how it should look:
Fixed:
Reference
https://vsuiguide.azurewebsites.net/topics/03%20Colors%20and%20Styling/03.03.05%20Using%20themed%20controls.html
Reviewers
I've included screen grabs of the updated dialogs below. @donokuda are there any layout tweaks you think are now necessary?
A spinning animation no longer appears when a comment is in progress (e.g. when logging in). The button does however become inactive when the comment is running and this is hopefully indication enough that something is happening. We should check this works as expected when logging in and when creating a repository.
We should check this is working for dark and light themes.
We should check this is working on all supported versions of Visual Studio.
Before and after
Before:
After:
When used with Get to Code workflow
Light theme
Dark theme
Dark theme
Login credentials:
Login 2FA:
Open from GitHub:
Create a repository:
Create a Gist:
Fork a repository:
Leaving an inline comment
Updated dialogs
Login credentials:
Login 2FA:
Create a repository:
Create a Gist:
Log out required - how do I make this dialog appear?