This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Fix 2FA when running on Visual Studio 2015 #2337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change from using TextBlockEnvironment1111PercentFontSizeStyleKey to TextBlockEnvironment122PercentFontSizeStyleKey (which exists in VS 2015).
Instead use the dialog forground color. The color was previously GHTextBrush (which wasn't VS themed).
Add scaling styles for built in Labels and TextBlocks on Visual Studio 2015 and up.
meaghanlewis
approved these changes
Apr 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Visual Studio 2015, authentication was getting stuck on username/password and not showing the 2FA UI.
What this PR does
VsResourceKeysrather than referencing style as a stringTextBlockEnvironment122PercentFontSizeStyleKeyinstead ofTextBlockEnvironment1111PercentFontSizeStyleKey(which doesn't exist in VS 2015)ErrorMessageStyleinstead ofGHTextBrush(which isn't themed for VS)How to test
Fixes #2336