Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[GHSA-cwvm-v4w8-q58c] Blind local file inclusion #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2023
Merged

[GHSA-cwvm-v4w8-q58c] Blind local file inclusion #2753

merged 1 commit into from
Oct 10, 2023

Conversation

EliahKagan
Copy link

Updates

  • Affected products

Comments
The fix in GitPython 3.1.35 was incomplete, as discussed in gitpython-developers/GitPython#1672. A new release, https://github.com/gitpython-developers/GitPython/releases/tag/3.1.37, includes a proper fix. The maintainer has updated the advisory associated with the repository, GHSA-cwvm-v4w8-q58c, to indicate that the fully patched version is 3.1.37 instead of any earlier version.

This change proposes the corresponding change in the GitHub Advisory Database, which would make both advisories convey the same, up-to-date information. The maintainer of GitPython, @Byron, has requested that this be done (gitpython-developers/GitPython#1672 (comment), gitpython-developers/GitPython#1672 (comment)).

This is based on a preference, in this case, to update the existing advisory and not to create a new one (as noted in the linked comments above). However, if this change to the advisory would not be sufficient to raise Dependabot alerts, that may be relevant.

@github
Copy link
Collaborator

github commented Sep 24, 2023

Hi there @stsewd and @Byron! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our highly-trained Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

@github-actions github-actions bot changed the base branch from main to EliahKagan/advisory-improvement-2753 September 24, 2023 08:19
@EliahKagan EliahKagan mentioned this pull request Sep 24, 2023
Merged
Byron
Byron approved these changes Sep 24, 2023
View reviewed changes
Copy link

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your help, much appreciated!

@taladrane
Copy link
Collaborator

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the Keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot. Please see CONTRIBUTING.md for more policy details.

@EliahKagan
Copy link
Author

I'm hoping this can still be reviewed by a member of the Security Curation Team.

  • If it can be merged, then that would update GitHub's global advisory database to include the version that really fixes the bug, which I think may result in automated tools such as Dependabot can notify users of the update (maybe a reviewer can speak to this).
  • If for any reason that is considered not to be feasible or appropriate, then alternatives can be explored, as noted in the description in this PR (see discussion in Add more checks for the validity of refnames gitpython-developers/GitPython#1672 for full context).

@darakian
Copy link
Contributor

Apologies on the delay. Getting to this now 🙇

@advisory-database advisory-database bot merged commit 7d5c904 into EliahKagan/advisory-improvement-2753 Oct 10, 2023
@advisory-database
Copy link
Contributor

Hi @EliahKagan! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!

@advisory-database advisory-database bot deleted the EliahKagan-GHSA-cwvm-v4w8-q58c branch October 10, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron approved these changes

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EliahKagan @github @taladrane @darakian @Byron