Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[GHSA-wjmp-wphq-jvqf] Passport-wsfed-saml2 allows SAML Authentication Bypass via Signature Wrapping #5508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kevinroh-okta
Copy link

@kevinroh-okta kevinroh-okta commented May 7, 2025

Updates

  • Description

Comments
The description for https://nvd.nist.gov/vuln/detail/CVE-2025-46572 does not match the description in this security advisory.

The description of the CVE is incorrect.

passport-wsfed-saml2 provides passport strategy for both WS-fed and SAML2 protocol. A vulnerability present starting in version 3.0.5 up to and including version 4.6.3 allows an attacker to impersonate any user in the Auth0 tenant during SAML authentication by crafting a SAMLResponse.

The bolded portion should be

allows an attacker to impersonate any user during SAML authentication by crafting a SAMLResponse.

@github
Copy link
Collaborator

github commented May 7, 2025

Hi there @kevinroh-okta! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

@github-actions github-actions bot changed the base branch from main to kevinroh-okta/advisory-improvement-5508 May 7, 2025 12:53
@shelbyc
Copy link
Contributor

shelbyc commented May 7, 2025

Hi @kevinroh-okta, I'm closing the PR since there aren't any changes to make to the global advisory GHSA-wjmp-wphq-jvqf, but the updated CVE description is now live at https://www.cve.org/CVERecord?id=CVE-2025-46572. As with #5509, it will take some time for the change to propagate to https://nvd.nist.gov/vuln/detail/CVE-2025-46572.

@shelbyc shelbyc closed this May 7, 2025
@github-actions github-actions bot deleted the kevinroh-okta-GHSA-wjmp-wphq-jvqf branch May 7, 2025 15:38
@kevinroh-okta
Copy link
Author

@shelbyc can you update the CVSS score in the CVE so it reflects the global advisory of 9.3?

@shelbyc
Copy link
Contributor

shelbyc commented May 7, 2025

@kevinroh-okta Sure! https://www.cve.org/CVERecord?id=CVE-2025-46572 is updated with the global advisory's CVSS now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants